ENH: Add support for local builds #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
changed the title
|
Okay this one is good to go @hoechenberger |
Comment on lines
+38
to
+39
| signing_identity_name: # [osx] Used for productsign | ||
| notarization_identity_name: # [osx] Used for codesign |
There was a problem hiding this comment.
This should be reverted for signing on CI, no?
There was a problem hiding this comment.
See changes in CI. Rather than always have it in and remove for pull requests, I do the opposite and always have it blank but add it for non-PRs (main/release builds). This makes it work better for local builds as a useful side effect.
larsoner
commented
May 24, 2022
Comment on lines
+117
to
+120
| if: ${{ runner.os == 'macOS' && github.event_name != 'pull_request' }} | ||
| shell: bash -el {0} | ||
| run: | | ||
| sed -i "" "s/9779L28NP8//" recipes/mne-python_1.0/construct.yaml | ||
| sed -i "" "s/_name: *# \[osx\]/_name: 9779L28NP8 # \[osx\]/" ${RECIPE_DIR}/construct.yaml |
There was a problem hiding this comment.
Specifically this set of changes where the logic is now: if not a pull request, add the _name (rather than: if a pull request, remove the _name)
|
This one should be good to go I think @hoechenberger |
|
Thanks @larsoner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assets/current_version.txtso that1.0appears in only two places now (that file andmne-python_1.0/recipes/construct.yaml(i.e., DRY)build_local.shto replicate remote build