Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra filtering example #432

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Extra filtering example #432

merged 5 commits into from
Jan 24, 2022

Conversation

rob-luke
Copy link
Member

No description provided.

@rob-luke rob-luke mentioned this pull request Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #432 (d5e77ab) into main (42c546a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          62       62           
  Lines        2356     2356           
  Branches      304      304           
=======================================
  Hits         2252     2252           
  Misses         48       48           
  Partials       56       56           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c546a...d5e77ab. Read the comment docs.

@rob-luke rob-luke merged commit 86d0050 into mne-tools:main Jan 24, 2022
echo "NumPy/pandas etc."
pip install --progress-bar off --upgrade --pre --only-binary ":all:" --no-deps -i "https://pypi.anaconda.org/scipy-wheels-nightly/simple" numpy pandas "scikit-learn>=0.24.2" dipy
echo "NumPy etc."
pip install --progress-bar off --upgrade --pre --only-binary ":all:" --no-deps -i "https://pypi.anaconda.org/scipy-wheels-nightly/simple" numpy "scikit-learn>=0.24.2" dipy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not great if you aren't testing --pre pandas, because it means the next time they cut a release user code will probably break. (You could require a specific version of pandas in setup.py, but then you could break someones' environment, which is worse than breaking one use case.)

Do you need help looking into the pandas issue here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need help looking into the pandas issue here?

Yes please @larsoner I havent started digging yet, I was just focused on getting the CIs green first. but seems I may have made more issues than I solved. Thanks

@rob-luke rob-luke deleted the filterex branch January 25, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants