-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra filtering example #432
Conversation
Codecov Report
@@ Coverage Diff @@
## main #432 +/- ##
=======================================
Coverage 95.58% 95.58%
=======================================
Files 62 62
Lines 2356 2356
Branches 304 304
=======================================
Hits 2252 2252
Misses 48 48
Partials 56 56 Continue to review full report at Codecov.
|
echo "NumPy/pandas etc." | ||
pip install --progress-bar off --upgrade --pre --only-binary ":all:" --no-deps -i "https://pypi.anaconda.org/scipy-wheels-nightly/simple" numpy pandas "scikit-learn>=0.24.2" dipy | ||
echo "NumPy etc." | ||
pip install --progress-bar off --upgrade --pre --only-binary ":all:" --no-deps -i "https://pypi.anaconda.org/scipy-wheels-nightly/simple" numpy "scikit-learn>=0.24.2" dipy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not great if you aren't testing --pre
pandas, because it means the next time they cut a release user code will probably break. (You could require a specific version of pandas in setup.py
, but then you could break someones' environment, which is worse than breaking one use case.)
Do you need help looking into the pandas issue here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need help looking into the pandas issue here?
Yes please @larsoner I havent started digging yet, I was just focused on getting the CIs green first. but seems I may have made more issues than I solved. Thanks
No description provided.