Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Minor fix and version bump #491

Merged
merged 13 commits into from
Oct 4, 2022
Merged

BUG: Minor fix and version bump #491

merged 13 commits into from
Oct 4, 2022

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Oct 3, 2022

@rob-luke okay to merge and cut a release? We'll want this for MNE 1.2 release

@larsoner
Copy link
Member Author

larsoner commented Oct 3, 2022

cc @drammock this is another repo that needed it

@larsoner
Copy link
Member Author

larsoner commented Oct 3, 2022

@rob-luke the failure is due to the deprecated plot_glm_topo, okay to remove it and call this version 1.0.0?

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #491 (50edc77) into main (437e85c) will decrease coverage by 0.56%.
The diff coverage is 81.63%.

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
- Coverage   95.88%   95.32%   -0.57%     
==========================================
  Files          68       68              
  Lines        2724     2715       -9     
  Branches      403      395       -8     
==========================================
- Hits         2612     2588      -24     
- Misses         54       64      +10     
- Partials       58       63       +5     
Impacted Files Coverage Δ
mne_nirs/conftest.py 100.00% <ø> (ø)
mne_nirs/statistics/__init__.py 100.00% <ø> (ø)
mne_nirs/visualisation/_plot_3d_montage.py 98.03% <50.00%> (ø)
mne_nirs/visualisation/_plot_GLM_topo.py 86.57% <74.19%> (-9.80%) ⬇️
mne_nirs/_version.py 100.00% <100.00%> (ø)
mne_nirs/simulation/_simulation.py 100.00% <100.00%> (ø)
mne_nirs/statistics/_glm_level_first.py 87.79% <100.00%> (-0.15%) ⬇️
mne_nirs/tests/test_examples.py 80.64% <100.00%> (-0.61%) ⬇️
mne_nirs/utils/tests/test_io.py 100.00% <100.00%> (ø)
mne_nirs/visualisation/__init__.py 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 3, 2022

This pull request introduces 1 alert when merging 078c12b into 437e85c - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@larsoner
Copy link
Member Author

larsoner commented Oct 3, 2022

@rob-luke okay to merge and release 0.4.0? If so, are you up for making the release?

@rob-luke
Copy link
Member

rob-luke commented Oct 4, 2022

Thanks @larsoner this is great.
I will make a release in next few days, but if you have time to cut a release before me that's awesome.
I definitely want to make a release before Sunday (fNIRS conference MNE tutorial).

@rob-luke rob-luke merged commit 0f61bb6 into mne-tools:main Oct 4, 2022
@larsoner larsoner deleted the bump branch October 4, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants