MAINT: Update dependencies and revitalize the CI pipeline #507
Conversation
Codecov Report
@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 69 69
Lines 2781 2781
Branches 397 397
=======================================
Hits 2652 2652
Misses 65 65
Partials 64 64
|
florin-pop
changed the title
.circleci/config.yml
Outdated
| @@ -13,7 +13,7 @@ jobs: | |||
| docker: | |||
| # Use 18.04 rather than 20.04 because MESA 20.0.8 on 18.04 has working | |||
| # transparency but 21.0.3 on 20.04 does not! | |||
| - image: cimg/base:stable-18.04 | |||
| - image: cimg/base:2023.03-18.04 | |||
There was a problem hiding this comment.
I'm not sure that this change is needed, I'll revert it and try again.
There was a problem hiding this comment.
This comment is very old and IIRC 22.04 mesa might actually be okay. Here I'd do whatever we do in MNE-Python's CircleCI config as things are tested/updated much more often there...
There was a problem hiding this comment.
(you'll need to make sure you have the MNE_3D_OPTION stuff equivalent between the two... IIRC we discovered the transparency bug was due to full-screen antialiasing being enabled or something)
.github/workflows/linux_pip.yml
Outdated
| @@ -27,6 +27,7 @@ jobs: | |||
| OPENBLAS_NUM_THREADS: '1' | |||
| PYTHONUNBUFFERED: '1' | |||
| PYTHON_VERSION: '3.10' | |||
| QT_DEBUG_PLUGINS: '1' | |||
| strategy: | |||
There was a problem hiding this comment.
This will be reverted as well before merge.
There was a problem hiding this comment.
Please leave in draft PR merge while there are things you intend to revert so we don't accidentally merge things that are intended for debugging.
There was a problem hiding this comment.
I realised I have access to revert the change ;) Done! THanks Florin
| @@ -33,7 +33,7 @@ xlrd | |||
| imageio>=2.6.1 | |||
| imageio-ffmpeg>=0.4.1 | |||
| traitlets | |||
| pyvista>=0.32,!=0.35.2,!=0.38.0,!=0.38.1,!=0.38.2,!=0.38.3 | |||
| pyvista>=0.32,!=0.35.2,!=0.38.0,!=0.38.1,!=0.38.2,!=0.38.3,!=0.38.4,!=0.38.5 | |||
There was a problem hiding this comment.
I'm not happy with this change. What do you think about pinning pyvista to >=0.32,<0.38?
There was a problem hiding this comment.
Agreed it's ugly, but IIRC the bug is/should be fixed in their main so it should work with the next release 🤷
|
Thanks @florin-pop it looks good to me. I also looked through the rendered docs and they were correct (including the 3d renders). Could you please revert the change you wanted to revert and then ping Eric to merge. |
I remembered I can revert the change myself ;) So we don't need to bug Eric now and I'll merge when all green |
|
This is absolutely super! Thanks @florin-pop |
This PR fixes #506 by introducing the following changes:
gitinstead of GitHub tarballs or zipballsfooter_items(which is deprecated) withfooter_startindoc/conf.pylibxcb-cursor0in addition to the rest of libxcb dependenciesThese fixes were mostly adaptations of changes introduced by @larsoner in https://github.com/mne-tools/mne-python/
Contributed with ❤️ by AE Studio