Extend SNIRF support to v1.1 #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #509 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 69 69
Lines 2781 2781
Branches 397 397
=======================================
Hits 2652 2652
Misses 65 65
Partials 64 64
|
|
Well that went smoother than expected. Thanks @florin-pop Please add a note to the https://github.com/mne-tools/mne-nirs/blob/main/doc/changelog.rst. Then I will merge once CI is green 🚀 |
florin-pop
force-pushed
the
update_snirf_to_1_1
branch
from
1f5857f
to
54533e2
Compare
|
Awesome, thanks @florin-pop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #505
Writing data into the SNIRF format will use v1.1 of this spec by default.
The diff between v1.0 and v1.1: https://github.com/fNIRS/snirf/compare/v1.1..v1.0#diff-a6c853dca5f1a8eb3e37e0de75889250190b68f3597e91f33489a05874aa49c4
Contributed with ❤️ by AE Studio