Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument theme of raw.plot() or config key does not work on macOS #10486

Closed
mscheltienne opened this issue Apr 2, 2022 · 7 comments · Fixed by #10487 or #10500
Closed

Argument theme of raw.plot() or config key does not work on macOS #10486

mscheltienne opened this issue Apr 2, 2022 · 7 comments · Fixed by #10487 or #10500
Labels

Comments

@mscheltienne
Copy link
Member

mscheltienne commented Apr 2, 2022

As spotted following the discussion here mne-tools/mne-qt-browser#83 the argument theme does not change the theme on either my macOS or Windows computer.

Sample code:

import mne


folder = mne.datasets.sample.data_path() / 'MEG' / 'sample'
raw = mne.io.read_raw(folder / 'sample_audvis_filt-0-40_raw.fif', preload=True)
raw.plot(theme='dark')
@mscheltienne
Copy link
Member Author

mscheltienne commented Apr 7, 2022

@larsoner can you re-open this one?
I am still getting a dark theme no matter the theme argument on my macOS with dark-mode enabled a the system-level.
Setting it in the MNE config with mne.set_config('MNE_BROWSER_THEME', 'light') does not get me the light theme either.

@mscheltienne mscheltienne changed the title Argument theme of raw.plot() does not work Argument theme of raw.plot() or config key does not work on macOS Apr 7, 2022
@larsoner
Copy link
Member

larsoner commented Apr 7, 2022

Same issue as mne-tools/mne-qt-browser#100 ?

@mscheltienne
Copy link
Member Author

I don't think so. I can give it a shot with the latest version of mne-qt-browser later; but in my case, the UI stays in dark mode no matter what. The entire UI.

@larsoner
Copy link
Member

larsoner commented Apr 7, 2022

Yes please test with latest MNE-Python and mne-qt-browser main

@mscheltienne
Copy link
Member Author

Fresh environment with both mne-python and mne-qt-browser installed from main. No luck, there is something wrong here.

folder = mne.datasets.sample.data_path() / 'MEG' / 'sample'
raw = mne.io.read_raw(folder / 'sample_audvis_filt-0-40_raw.fif', preload=True)
raw.plot(theme='light')

Screenshot 2022-04-07 at 15 55 12

@larsoner larsoner reopened this Apr 7, 2022
@larsoner
Copy link
Member

larsoner commented Apr 7, 2022

Can you investigate a bit? If not, I can try to look in a bit

@mscheltienne
Copy link
Member Author

mscheltienne commented Apr 7, 2022

I can look at it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants