Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar and statusbar widgets are not in dark mode when my system is in dark mode #100

Closed
hoechenberger opened this issue Apr 5, 2022 · 2 comments · Fixed by mne-tools/mne-python#10500

Comments

@hoechenberger
Copy link
Member

So this is what it looks like on macOS, makes my eyes bleed:

Screen Shot 2022-04-05 at 22 18 08

@hoechenberger hoechenberger changed the title Widgets are not in dark mode when my system is in dark mode Toolbar and statusbar widgets are not in dark mode when my system is in dark mode Apr 5, 2022
@larsoner
Copy link
Member

larsoner commented Apr 5, 2022

I fixed this in #66, I suspect some PR to MNE-Python after mne-tools/mne-python#10414 (which was needed as well) broke this actually :(

cc @GuillaumeFavelier this is probably related to some of the recent theme refactoring(s). We have to be careful about when we set stylesheets and such.

@hoechenberger can you 1) check that switching to MNE-Python [6e2c52c](https://github.com/mne-tools/mne-python/commit/6e2c52c592be02de3c798c98b21cfdc1d6e264ad) works, and then if so 2) git bisect to figure out which PR broke things? I'm guessing it might be mne-tools/mne-python@4301092 / mne-tools/mne-python#10456 because IIRC it messed with themes most recently, but it's very possible I'm wrong!

@hoechenberger
Copy link
Member Author

In fact I didn't even check my version of MNE-Python, I will check to be running the latest version tomorrow to see if the problem persists. Maybe there's nothing wrong after all …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants