-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: Rework CoregistrationUI fiducial I/O widgets & add save button #10242
MRG: Rework CoregistrationUI fiducial I/O widgets & add save button #10242
Conversation
I have multiple questions/remarks:
|
We call
Why's that?
I wasn't aware of this one, I'll have a look.
Absolutely! Will do. |
When I designed the callbacks to set translation and rotation values for example, I used a In your case though, you do not use local variables but attributes of the class, it should be okay but I did not test your branch yet. |
Ah yes, I see what you mean. Yes this is specifically what I ensured before choosing to use |
Factored out from mne-tools#10242
Factored out from mne-tools#10242
Factored out from mne-tools#10242
Factored out from #10242
d36a609
to
c31d3b8
Compare
Partially extraced from mne-tools#10242 and mne-tools#10224 - status bar is now stored in `self._widgets` - `_forward_widget_command()` has a docstring and new functionality (extracted from mne-tools#10224)
…oreg-ui-fiducial-io-widgets
@GuillaumeFavelier I think this one is good to merge now! Basically what we cooked up together yesterday, plus some really minor changes and fixing the bugs we encountered (except for the DigPoints showing with unlocked fiducials when switching subjects) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my only nitpick @hoechenberger
About the bug, I will update #8833 👍 For now, the temporary workaround is to lock then unlock the fiducials :(
This is the last remaining bit of the #10237 rework, incorporating suggestions and feedback I've meanwhile received.
Closes #10237
I've removed the
_fiducials_file
traitlet as it's not needed anymore. I've moved its functionality to other methods.Screen.Recording.2022-01-25.at.10.02.50.mov
There's a bug related to the digpoints still showing even though the fiducials are unlocked. I've left an extensive comment in the source. This is probably something that needs to be solved in a separate PR unless @GuillaumeFavelier has an immediate idea? At any rate, I don't think this PR introduced this problem 😅
cc @agramfort