ENH: load icon #10458
Merged
ENH: load icon #10458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All green for now, good news 👍 |
|
@cbrnr you are our QT expert on this :) can you please have a look? thx |
|
Same here, I think we should fix cbrnr/mnelab#339 first. |
GuillaumeFavelier
force-pushed
the
mnt/load_icon
branch
from
a013f97
to
382039b
Compare
GuillaumeFavelier
force-pushed
the
mnt/load_icon
branch
from
382039b
to
e00cc19
Compare
|
This PR is ready from my end. |
larsoner
reviewed
Apr 1, 2022
Comment on lines
+513
to
514
| self._window_load_icons() | ||
| self._window_set_theme() |
There was a problem hiding this comment.
Does it _window_load_icons have to come after the _window_set_theme so that the correct theme is loaded?
There was a problem hiding this comment.
_window_set_theme() updates the icons as well so the order should not matter in here
larsoner
approved these changes
Apr 1, 2022
|
Thanks @GuillaumeFavelier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors icon loading in the GUI API and replaces the "Load" buttons by a 📁 icon in the coreg app.
It makes for a subtle change:
This PR cannot be merged before #10456
It's an item of #8833