-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coreg tutorial typos #10716
Fix coreg tutorial typos #10716
Conversation
The |
automated MEG-MRI coregistration via scripting. | ||
automated MEG-MRI coregistration via scripting. Generally the results of | ||
this approach are consistent with those obtained from manual | ||
coregistration :footcite:`HouckClaus2020` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coregistration :footcite:`HouckClaus2020` | |
coregistration :footcite:`HouckClaus2020`. |
|
||
data_path = mne.datasets.sample.data_path() | ||
subjects_dir = data_path + '/subjects' | ||
data_path = Path(mne.datasets.sample.data_path()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already a Path
object, so no need to import and convert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was an attempt to make the use of the Path
object more obvious. Maybe a comment instead of the redundant import/conversion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is documented. If you think a comment is necessary to ahead and add it.
@mmagnuski I knew that, and still I did this. I've removed the errors that I'd introduced and added an explicit call to Also, the tutorial mentions |
I don't think we have an example showing the usage of mne.scale_mri. Might be useful to add in the future. |
Thanks @jhouck ! |
* upstream/main: MRG: In Report, allow to add multiple figure or image elements to the same content block ("section") (mne-tools#10694) CI: Add style conditional (mne-tools#10723) Fix coreg tutorial typos (mne-tools#10716) MAINT: Deal with nibabel deprecation (mne-tools#10719)
Reference issue
Minor cleanup, no issue
What does this implement/fix?
I noticed a few minor typos (e.g., slashes not quoted) and have addressed. Copy-and-paste into python should now work for this one. Also added a cite for the paper that assessed the reliability of the method.