-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fixes for ARM architecture #10763
Conversation
@hoechenberger or @agramfort if either of you can replicate numpy/numpy#21756 locally and can comment on the NumPy issue, it might help move things forward -- and also make sure I'm not doing something wrong! |
OMG this is horrible 😱 😱 |
Seems to be a |
@larsoner Shall we briefly catch up on Discord? |
For all the others following this thread, the problem seems to be related to OpenBLAS, and switching to a different BLAS implementation seems to fix at least this here test case. |
Sorry I was fighting with https://gitlab.kitware.com/vtk/vtk/-/issues/18559 for the last hour instead :) I think the most likely scenario is that it's an OpenBLAS issue that probably needs to be fixed at the OpenBLAS end. But now that it has been replicated on two machines, the NumPy folks should know how to move things forward. So I think we wait a couple of days and see if they make progress. In the meantime I think we wait on the M1 installers :( |
Can you try to conditionally use |
I guess we could try this, but IIRC Accelerate was not really well supported by SciPy last time I saw it discussed. Feel free to try locally and run |
@agramfort feel free to merge if you're okay with the mxne changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nitpick. than +1 for MRG on my side
thx @larsoner
Great work, @larsoner! |
Bad things found so far on my M1 machine:
LinAlgError
to trigger onnp.linalg.solve
for rank deficiency on arm64. I changed themxne
code to use a SVD, which actually seems faster (!?) so I think this is a tolerable change at least. This probably deserves an upstream bug report at some point, but isolating it isn't the easiest thing...The second one is a show stopper. I don't think we can safely release or advocate for M1-based installers until it's fixed.
There are a bunch of
test_linalg.py
errors that I see locally that are likely related, but I don't want to bother looking into them until we can trustsvd
.Helps with #10759