-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH, MRG] Add coregistration video and execute GUI in tutorial to show window & add show and block to GUIs #10802
Conversation
Alright! A bit of the code is a tiny bit inelegant but that will be fixed with future PRs that slightly refactor the window classes so that they don't depend on the 3D renderer, harmonizing between the |
@alexrockhill in the video you pick the fiducials too high. In this subject the LPA and RPA should be just just below the targus |
Ok, I will reshoot picking as in here https://www.fieldtriptoolbox.org/faq/how_are_the_lpa_and_rpa_points_defined/ |
Ok new video is up, looks good https://output.circle-artifacts.com/output/job/a249d7a8-3e0b-4508-9864-8bca3bc5fa25/artifacts/0/dev/auto_tutorials/forward/20_source_alignment.html#defining-the-headmri-trans-using-the-gui. I did notice that there was a reference to toggling head points that is defunct so I'll fix that. |
I noticed that the text instructions were out-of-date so this fixes those as well. |
nice !
2 nitpicks:
- you can use omit button after the first ICP fit to remove the outlier
point
- the scaling option is more if you have an individual digitization (aka
the head shape points)
but you don't have the MRI. You use then the dig points as proxy for the
head size etc.
Message ID: ***@***.***>
… |
Ok, I'll give the video one more shot |
@agramfort, if you have time for one more look, sorry for the bad takes, you can playback at double speed and it's only two minutes 😄 https://youtu.be/ALV5qqMHLlQ |
Maybe something for the text (I don't want you to redo the video again), but I have been wondering where the exact location of a fiducial marker actually is. Is it at some vertex? Or the center of mass inside the shape? Probably worth mentioning because that shape has a non-negligible shape. |
I was going off https://www.fieldtriptoolbox.org/faq/how_are_the_lpa_and_rpa_points_defined/ @cbrnr, we could link that in the tutorial |
No, I meant which point in that fiducial marker (two stacked pyramids) is the origin? Should I use the top vertex or the bottom one to set the fiducial location? |
I think it's the center of mass of the shape... does that help? |
Sure! We should mention this. |
@cbrnr, I added that info in the text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
video is great !
are all the changes in this PR related? I see you touch stuff in GUI code and I want to know how deeply I need to review this
If you could give it 5 minutes that would be really helpful but I'm not too worried about things breaking since I'm mostly just using things that have worked in the other GUI for the |
@agramfort is happy with the video, I'm happy with the code, and I don't see any unresolved comments so in it goes, thanks @alexrockhill ! |
Fixes #9451, fixes #10801.