fix eeglab export rawarray filenames #10927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
cbrnr
reviewed
Jul 14, 2022
cbrnr
reviewed
Jul 14, 2022
drammock
reviewed
Jul 14, 2022
mne/export/_eeglab.py
Outdated
Comment on lines
20
to
24
| try: | ||
| if not (raw.filenames[0].endswith('.fif')): | ||
| drop_chs.append('STI 014') | ||
| except AttributeError: # mne.io.RawArray has no filenames attribute | ||
| pass |
There was a problem hiding this comment.
I think I'd be more comfortable with:
Suggested change
| try: | |
| if not (raw.filenames[0].endswith('.fif')): | |
| drop_chs.append('STI 014') | |
| except AttributeError: # mne.io.RawArray has no filenames attribute | |
| pass | |
| # RawArray doesn't have `filenames` attribute | |
| if hasattr(raw, 'filenames') and not raw.filenames[0].endswith('.fif'): | |
| drop_chs.append('STI 014') |
the except Error: pass pattern always makes me nervous that silent bugs might slip through
There was a problem hiding this comment.
In fact, there is a misunderstanding by my comment.
RawArray has filenames attribute but RawArray.filenames[0]==None.
agramfort
approved these changes
Jul 15, 2022
cbrnr
approved these changes
Jul 15, 2022
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
|
thx @0Reza |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
No filenames Attribute in mne.io.RawArray #10921
What does this implement/fix?
Add a try-except structure to catch the AttributeError and do nothing.
Additional information