Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Fix CIs #10933

Merged
merged 1 commit into from
Jul 18, 2022
Merged

MAINT: Fix CIs #10933

merged 1 commit into from
Jul 18, 2022

Conversation

larsoner
Copy link
Member

The __repr__ is not as good as sklearn but hopefully good enough. They went with something complicated that wasn't an easy try/except port:

https://github.com/scikit-learn/scikit-learn/blob/b5091a56186964189b1ffb719fa945554f9461fb/sklearn/base.py#L213-L230

Should fix https://github.com/mne-tools/mne-python/runs/7395864622?check_suite_focus=true

@larsoner larsoner mentioned this pull request Jul 18, 2022
Merged
agramfort
agramfort approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @larsoner

the pprint of sklearn how now gone to all new level...

@larsoner larsoner merged commit 6955f97 into mne-tools:main Jul 18, 2022
@larsoner larsoner deleted the ci branch July 18, 2022 21:59
@drammock drammock mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsoner @agramfort