Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remaining resp: respiration!=response #11035

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Aug 15, 2022

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@hoechenberger hoechenberger enabled auto-merge (squash) August 15, 2022 15:40
@sappelhoff
Copy link
Member Author

Also, there is an error in the changelog. Search for: read_raw_bti erroneously treated response channels as respiratory channels (#8855

the "8855" link seems wrong :)

@larsoner
Copy link
Member

@sappelhoff feel free to fix the changelog, too

@sappelhoff
Copy link
Member Author

feel free to fix the changelog, too

done, I found the correct one.

@larsoner larsoner added the backport-candidate on-merge: backport to maint/1.7 label Aug 15, 2022
@larsoner larsoner disabled auto-merge August 15, 2022 17:44
@larsoner larsoner merged commit 7511bf7 into mne-tools:main Aug 15, 2022
@larsoner
Copy link
Member

Thanks @sappelhoff !

@sappelhoff sappelhoff deleted the resp/fix branch August 15, 2022 18:33
@larsoner
Copy link
Member

Backported

larsoner pushed a commit that referenced this pull request Aug 19, 2022
* fix remaining resp: respiration!=response

* fix changelog link
@larsoner larsoner added backported and removed backport-candidate on-merge: backport to maint/1.7 labels Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants