Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Better issue forms #11101

Merged
merged 5 commits into from
Aug 30, 2022
Merged

MAINT: Better issue forms #11101

merged 5 commits into from
Aug 30, 2022

Conversation

larsoner
Copy link
Member

Follows mne-tools/mne-bids#1056 but adapts to MNE-Python

@drammock feel free to look and merge if you're happy

@larsoner larsoner marked this pull request as ready for review August 27, 2022 12:07
Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggested wording improvements. +1 for merge to try them out ASAP, we can always come back and tweak these again later.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/documentation.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
Co-authored-by: Daniel McCloy <dan@mccloy.info>
@hoechenberger hoechenberger enabled auto-merge (squash) August 30, 2022 15:37
@larsoner
Copy link
Member Author

@hoechenberger if you want to make similar changes for MNE-BIDS, feel free. The validation is cool, as is the render. Also the feature request boxes over there seem more appropriate to a bug report.

@larsoner
Copy link
Member Author

@drammock I think I covered your comments, including the Python rendering. Feel free to merge if you're happy

@drammock drammock disabled auto-merge August 30, 2022 15:44
@drammock drammock merged commit a5acbec into mne-tools:main Aug 30, 2022
@hoechenberger
Copy link
Member

@hoechenberger if you want to make similar changes for MNE-BIDS, feel free. The validation is cool, as is the render. Also the feature request boxes over there seem more appropriate to a bug report

Happily delegating to @sappelhoff 😁😁😁

sappelhoff added a commit to mne-tools/mne-bids that referenced this pull request Aug 30, 2022
larsoner added a commit to larsoner/mne-python that referenced this pull request Aug 30, 2022
* upstream/main: (25 commits)
  DOC: Exclude some implicit refs in doc build (mne-tools#10433)
  MAINT: Better issue forms (mne-tools#11101)
  [FIX] Typo in example (mne-tools#11118)
  [MRG] Improve interpolation of bridged electrodes (mne-tools#11094)
  BUG: Spectrum deprecation cleanup [circle deploy] (mne-tools#11115)
  Add API entry list and map (mne-tools#10999)
  Add legacy decorator (mne-tools#11097)
  [ENH, MRG] Add time-frequency epoch source estimation (mne-tools#11095)
  Revert "Add error message when conversion of EEG locs to [circle deploy] (mne-tools#11104)
  MRG: Fixes for mne-tools#11090 (mne-tools#11108)
  add test for edf units param (mne-tools#11105)
  BUG: Improve logic for bti (mne-tools#11102)
  add spectrum class (mne-tools#10184)
  ENH : add units parameter to read_raw_edf in case units is missing from the file (mne-tools#11099)
  ENH: Add temperature and galvanic (mne-tools#11090)
  Add error message when conversion of EEG locs to head space fails (mne-tools#11080)
  DOC: removed unnecessary line in PSF example (mne-tools#11085)
  FIX: Update helmet during ICP (mne-tools#11084)
  Fix various typos (mne-tools#11086)
  DOC: Rel
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants