Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add tutorial on time-frequency source estimation with STC viewer GUI #10920 #11352
[ENH] Add tutorial on time-frequency source estimation with STC viewer GUI #10920 #11352
Changes from 63 commits
c6c34c0
9d5cee0
9b39a21
4b5da95
75369e1
23e6346
ebf6200
38c768c
55060ef
78badbf
d8eff54
6cd7ad0
47d32c3
35868e5
0c0989f
afd06ed
88e2679
9318146
ebcd626
70af173
f46ed03
acd6cf6
ee79a2d
d28d593
583e0ad
0d54edc
8c647d8
67d80cb
43e7df8
6e845e6
7bd5337
e4cb526
178baa0
62a5331
7bdf36c
3f471a9
adcb02d
9bb8ad0
3cf7634
7b57d89
8ac9b3b
aac757f
5200cae
b28bf70
602aece
dc78c56
865f001
1f0f8fc
50d2522
be7ec61
fc60a86
04d39ea
c48db06
3e09bd1
7fc0e98
fc57850
a66c6b5
97abfa0
0c6b226
f710eaf
32c6931
6284330
5c67a70
a222c6a
1d0b5fd
2e31eda
c02eda5
cd8b2ea
b96ceb1
38eaea0
c0ee101
0090724
00a5d33
860b5f9
1452734
252cf83
fb2905d
127f883
f72b214
5f14e51
4834d08
d8eead1
bafbaac
5705f78
2a5493d
b635511
6b1874d
273392d
af15f01
0544e9d
50198f3
94f57e4
2cd7738
9e4bc5a
aaca27a
e296dde
aa6354a
c1f7c56
cda6c0a
416bfb7
6bb3bc2
921b74f
428feb0
8fb0893
c68c789
bf5ad21
73d9e3d
59afa5e
d380f7e
f7baa08
3e3e613
8b479be
99e6c0c
0449ef2
5ea2015
e49c948
49f3539
8b350e3
42b2014
1548cfe
2afa8e7
dfeee13
83bee35
d84a8ce
01de538
dff4ae3
2302226
9c18b47
33b65ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I fully understand this comment. Do you mean that weighted averaging is taken care of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That line just got moved, I didn't change it in any way. I didn't write it so I'm not sure the answer, I would infer from the authors that Marijn wrote it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well given that we both don't understand it, it should probably be replace it with something that is easier to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am no MNE solution expert and I also see why this is necessary for the plotting here - but is this something we should comment on in the example @larsoner ? It is maybe not the preferred thing to use a volume source space for a distributed model like MNE, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The performance seems to be pretty good in this example--somatosensory stimulation is localized to S1 so I'm not sure that it needs qualification. Also, the level of that qualification shouldn't be in a tutorial, it should be when you go to make the forward model with a volume source space if that's not recommended. I'd open a separate issue about it if you want to discuss recommendations for source modeling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point is that if we do something unusual here (which I think we do), we should probably add a note for the user that this is not necessarily recommended to do in other contexts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done in another example here: https://mne.tools/dev/auto_examples/inverse/compute_mne_inverse_volume.html#sphx-glr-auto-examples-inverse-compute-mne-inverse-volume-py and it's not noted as usual. Again, I'm not saying your wrong, I'm just saying let's start a separate issue to talk about this so we stay on track in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, although this is an example on doing this specifically, while here we do it in passing. I've talked to a bunch of people about using a volumetric model with MNE, and they all said it is not advisable in most cases. What speaks against adding a note or comment that says "Please not that using a volumetric source space with a minimum norm estimation algorithm is not necessarily advised in all contexts." or something like this?
@larsoner - thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this makes sense, all the options are described below, including a list of source estimates. It's a bit complicated so I think it's best to enumerate. For clarity, I will number them though.