[ENH] Read annotation duration from SNIRF files. #11397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agramfort @larsoner @drammock this PR is ready for review. There is a failing CI, but I think it's unrelated. Thanks! |
larsoner
reviewed
Jan 2, 2023
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Jan 3, 2023
* upstream/main: [ENH, MRG] Add info save method (mne-tools#11401) MAINT: Sanitize name lists (mne-tools#11399) [ENH] Read annotation duration from SNIRF files. (mne-tools#11397)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Before this PR, when reading SNIRF files, the annotation durations were ALL set to 1.0
What does this implement/fix?
This PR changes the
read_raw_snirffunction to read annotation durations from the file.Additional information
Relevant file type definition is here: https://github.com/fNIRS/snirf/blob/master/snirf_specification.md#nirsistimjdata
A PR has been opened to add correct stimulus duration to SNIRF writing at mne-tools/mne-nirs#497