Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: eyetracking plot_heatmap function #11798

Merged
merged 40 commits into from
Oct 12, 2023
Merged

Commits on Jul 12, 2023

  1. Configuration menu
    Copy the full SHA
    4b256c6 View commit details
    Browse the repository at this point in the history
  2. FIX: next matplotlib

    scott-huberty committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    318d974 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    895f2ea View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Configuration menu
    Copy the full SHA
    e37dcd3 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Configuration menu
    Copy the full SHA
    d8575a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. ENH, DOC: refactor plot_gaze and add to API doc

    - took another pass at this function to simplify it. mainly, made
    - plot_heatmap_array private
    scott-huberty committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    320fc39 View commit details
    Browse the repository at this point in the history
  2. DOC: update eyelink dataset and its description

    - added a second eyelink dataset for a heatmap tutorial
    scott-huberty committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    09ce77d View commit details
    Browse the repository at this point in the history
  3. DOC: add a new eyetracking tutorial

    - added a new tutorial for plotting eyetracking heatmaps
    - included a brief example of heatmap plotting in current tutorial
    scott-huberty committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    26888cd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2cfc3e1 View commit details
    Browse the repository at this point in the history
  5. DOC: fix typo

    scott-huberty committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0e8985f View commit details
    Browse the repository at this point in the history
  6. FIX, DOC: add alpha parameter to API docstring

    - the alpha parameter was missing from the docstring which caused a numpydoc error
    scott-huberty committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    26054f0 View commit details
    Browse the repository at this point in the history
  7. DOC: in tutorial, dont baseline correct eyegaze channels

    - This is a tough one. In the "working with eye tracker data" tut, I DO want to baseline correct the pupil channel, but I DONT want to baseline correct eyegaze channels. I am not sure that it EVER makes sense to baseline correct eyegaze channels, given that they USUALLY represent a gaze coordinate, but I need to think about this more.
    - I may open a separate ticket about this matter
    scott-huberty committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    aec89f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Configuration menu
    Copy the full SHA
    dd65afe View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. FIX: Need module

    larsoner committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    29eb623 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    324d74e View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. FIX: Code suggestions from Eric

    Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
    
    - Use a smarter way to find gaze position channels, dont rely on the ch_name
    - No need to mask out values outside the width and height, histogram2d will do it for you
    - remove bin_width parameter in favor of relying on sigma param
    scott-huberty committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    6962df9 View commit details
    Browse the repository at this point in the history
  2. TST: add a test

    scott-huberty committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    20e3056 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Apply suggestions from code review [ci skip]

    Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
    scott-huberty and larsoner authored Oct 2, 2023
    Configuration menu
    Copy the full SHA
    6bedba6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0a2caa View commit details
    Browse the repository at this point in the history
  3. FIX, DOC: Code suggestions from eric and mne.utils.doc addition

    - I added a new entry into the doc_dict in mne.utils.doc for the matplotlib cmap parameter, which I believe could prove to be useful elsewhere, for example in mne.viz.misc.plot_csd. FWIW The cmap_topo docstring that was already in the doc_dict says that if None is passed then "reds" will be used. But For any mne functions that have cmap=None as the default, if None is passed into the matplotlib function, the default will actually be whatever matplotlib's default is, which is usually viridis.
    scott-huberty committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    c421d50 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    379abf0 View commit details
    Browse the repository at this point in the history
  5. DOC: be more memory efficient in eyetracking tutorial

    - memory profiling revealed that this tutorial was using around 700mb of memory.
    scott-huberty committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    6531e53 View commit details
    Browse the repository at this point in the history
  6. FIX: obvious typo....

    scott-huberty committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    3b17ec1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6085bc5 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Apply suggestions from code review [ci skip]

    Co-authored-by: Daniel McCloy <dan@mccloy.info>
    Co-authored-by: Mathieu Scheltienne <mathieu.scheltienne@gmail.com>
    3 people authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    8305a1d View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    baaa7bc View commit details
    Browse the repository at this point in the history
  2. Simplify tutorial

    scott-huberty committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    b5c6079 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    093a003 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7c693db View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bba5d7d View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    927fdad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c5b8f1 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/main' into plot_gaze

    - Had to fix conflict in "mne/viz/__init__" because prior PR changed the init files to work better with lazy loader. Just accepted incomign change
    scott-huberty committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    df33e33 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Configuration menu
    Copy the full SHA
    7ecc759 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9896f2b View commit details
    Browse the repository at this point in the history
  3. TST: Make test more direct

    Co-authored-by: Daniel McCloy <dan@mccloy.info>
    scott-huberty and drammock committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    32a3e64 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. DOC: minor documentation revisions suggested by Dan

    Co-authored-by: Daniel McCloy <dan@mccloy.info>
    scott-huberty and drammock committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5add060 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea7e653 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Configuration menu
    Copy the full SHA
    0e3e495 View commit details
    Browse the repository at this point in the history
  2. FIX: Order

    larsoner committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    d89ef77 View commit details
    Browse the repository at this point in the history