Fix typo in contributing guide #12335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrnr
requested review from
larsoner,
drammock,
agramfort and
dengemann
as code owners
agramfort
approved these changes
Jan 4, 2024
|
I think it's done via the label 'no-changelog-entry-needed'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a missing colon. The contributing guide mentions that changelog entries can be skipped for such minor changes, but it doesn't say how (the check is failing). I think it would be good to be explicit here (i.e. it is supposed to fail). Let me know how it's done and I can add a sentence in this PR.