Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh browserfig UI events #12819

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Enh browserfig UI events #12819

wants to merge 20 commits into from

Commits on Aug 27, 2024

  1. add event_channel hook to qt

    @nmarkowitz
    nmarkowitz committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7266c23 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Merge branch 'mne-tools:main' into ENH-browserfig-ui-events

    @nmarkowitz
    nmarkowitz authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    0dc0205 View commit details
    Browse the repository at this point in the history

  2. Update mne/viz/ui_events.py 

    Co-authored-by: Marijn van Vliet <w.m.vanvliet@gmail.com>
    @nmarkowitz @wmvanvliet
    nmarkowitz and wmvanvliet authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c9e19f1 View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    52e446f View commit details
    Browse the repository at this point in the history

  4. Add TimeChange event to matplotlib-based browser.

    @wmvanvliet
    wmvanvliet committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f83401e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Change behavior of TimeChange event

    @wmvanvliet
    wmvanvliet committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    ebdc6d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. add ui events

    @nmarkowitz
    nmarkowitz committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    1e47916 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ENH-browserfig-ui-events

    @nmarkowitz
    nmarkowitz authored Aug 31, 2024
    Configuration menu
    Copy the full SHA
    208375c View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Update mne/viz/ui_events.py 

    Co-authored-by: Marijn van Vliet <w.m.vanvliet@gmail.com>
    @nmarkowitz @wmvanvliet
    nmarkowitz and wmvanvliet authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    09ae6c6 View commit details
    Browse the repository at this point in the history

  2. Update mne/viz/ui_events.py 

    Co-authored-by: Marijn van Vliet <w.m.vanvliet@gmail.com>
    @nmarkowitz @wmvanvliet
    nmarkowitz and wmvanvliet authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    50f4a74 View commit details
    Browse the repository at this point in the history

  3. Update mne/viz/ui_events.py 

    Co-authored-by: Marijn van Vliet <w.m.vanvliet@gmail.com>
    @nmarkowitz @wmvanvliet
    nmarkowitz and wmvanvliet authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    23119d1 View commit details
    Browse the repository at this point in the history

  4. Update mne/viz/ui_events.py 

    Co-authored-by: Marijn van Vliet <w.m.vanvliet@gmail.com>
    @nmarkowitz @wmvanvliet
    nmarkowitz and wmvanvliet authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    53ce0e8 View commit details
    Browse the repository at this point in the history

  5. implement TimeBrowse

    @nmarkowitz
    nmarkowitz committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f65f2cf View commit details
    Browse the repository at this point in the history

  6. Merge branch 'mne-tools:main' into ENH-browserfig-ui-events

    @nmarkowitz
    nmarkowitz authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8b529e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. ChannelBrowse and TimeBrowse and mpl browser

    @nmarkowitz
    nmarkowitz committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    587775e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ENH-browserfig-ui-events' of https://github.com/nmarkow… 

    …itz/mne-python into ENH-browserfig-ui-events
    @nmarkowitz
    nmarkowitz committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    66716c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Refactor TimeChange, TimeBrowse, ChannelBrowse events. 

    Mouse and keypresses no longer directly update the plot, but instead
generate the appropriate UI events. Figures always listen and respond to
their own UI events, which is where the updating of the figure happens.
This way, there is a single place in the code where checking of corner
cases, etc. happens.

In addition, the matplotlib xdata timeline is different from actual
times in the Raw object. UI events should always be meaningful outside
of the figure. Hence, TimeChange and TimeBrowse should give the selected
times in terms of the original Raw object. Various translations
therefore need to happen.
    @wmvanvliet
    wmvanvliet committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f4366c5 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0a0f402 View commit details
    Browse the repository at this point in the history

  3. some bugfixes and cleanup

    @wmvanvliet
    wmvanvliet committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    04b8b7c View commit details
    Browse the repository at this point in the history

  4. some bugfixes and cleanup

    @wmvanvliet
    wmvanvliet committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2734823 View commit details
    Browse the repository at this point in the history