-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerate environment.yml file from pyproject.toml #12914
Conversation
ebc9fc2
to
1fb1e27
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It occurred to me that any autogenerated file should have a comment so I just pushed a tiny commit to add this to the top of the env file:
# THIS FILE IS AUTO-GENERATED BY tools/hooks/update_environment_file.py AND WILL BE OVERWRITTEN
similar to what we have in doc/sphinxext/credit_tools.py
Ughhhh looks like I was wrong about |
for more information, see https://pre-commit.ci
I am a bit mystified by both the pip-pre failure and the conda one. Looking at a diff of the sorted |
I'm scratching my head too 😕 |
the numpy config on
The line |
comparing that to the
here we see a reasonable version number, known configuration strings, and a different |
ok, yep:
|
disabling auto-merge because I'm not certain if 69a790d will actually be necessary anymore. |
@@ -9,7 +9,7 @@ if [ "${TEST_MODE}" == "pip" ]; then | |||
python -m pip install $STD_ARGS --only-binary="numba,llvmlite,numpy,scipy,vtk,dipy" -e .[test,full] "numpy<2" | |||
elif [ "${TEST_MODE}" == "pip-pre" ]; then | |||
${SCRIPT_DIR}/install_pre_requirements.sh | |||
python -m pip install $STD_ARGS --pre -e .[test] | |||
python -m pip install $STD_ARGS --pre -e .[test_extra] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the corresponding branch in github_actions_dependencies.sh
uses test_extra
too, and it's needed for utils/tests/test_config.py
(I think previously it was passing on windows by chance)
Thanks @drammock ! |
@larsoner do you have any idea why we were suddenly getting MKL? I never did track down a cause. |
No idea. Could be unfortunate timing with some |
* upstream/main: eegbci api: allow downloading multiple subjects (mne-tools#12918) DOC: Document Linux desktop workaround (mne-tools#12900) Allow exporting edf where a channel contains only constant values (mne-tools#12911) Autogenerate environment.yml file from pyproject.toml (mne-tools#12914)
closes #12903
Easiest to review a few specific commits:
environment.yml
entries so that subsequent hook-induced changes to that file are easier to seeNote that this does not address #12903 (comment) --- I figured easier to get this one in / tested and then deal later with cross-repo syncing.