MRG: Use a text slider widget #7186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 tasks
|
Travis is happy except the job on macOS. I restarted it. |
Codecov Report
@@ Coverage Diff @@
## master #7186 +/- ##
==========================================
- Coverage 89.76% 89.76% -0.01%
==========================================
Files 445 445
Lines 79741 79723 -18
Branches 12755 12753 -2
==========================================
- Hits 71579 71561 -18
Misses 5369 5369
Partials 2793 2793 |
GuillaumeFavelier
changed the title
|
What do you think @agramfort , @larsoner ? |
|
works like a charm |
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new text widget introduced recently in PyVista and avoid the creation of a custom slider.
This is refactoring, the features won't change.
It's an item of #7162