-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: Update time slider label #7263
MRG: Update time slider label #7263
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7263 +/- ##
==========================================
- Coverage 89.79% 89.79% -0.01%
==========================================
Files 447 447
Lines 80506 80518 +12
Branches 12873 12878 +5
==========================================
+ Hits 72289 72299 +10
- Misses 5390 5391 +1
- Partials 2827 2828 +1 |
works great except that now if I hide the controls I've lost the time information. It should appear as before. |
Good catch! I'll fix this one. |
Actually @agramfort I see 2 ways to solve this issue:
|
We want a time label visible, it's useful. Why not show the old actor when not in interactive mode, but hide it in interactive mode? It won't scale in non-interactive mode but I think that's okay. (Personally I think it would be better if none of the text actors scaled, it's how standard UI and plotters like mpl work.) |
Going for option 1 then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works like a charm for me
Works for me as well, thanks @GuillaumeFavelier |
* Update time slider * Remove unused variable * Refactor set_time_point * Bring back time_actor when the interface is hidden
* Update time slider * Remove unused variable * Refactor set_time_point * Bring back time_actor when the interface is hidden
This PR updates the slider time label instead of the default time actor. It improves consistency so now the size of the time label scales with the window size.
Known issue
It's an item of #7162