-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add help window to the _TimeViewer #7305
Merged
larsoner
merged 12 commits into
mne-tools:master
from
GuillaumeFavelier:time_viewer_help_window
Feb 13, 2020
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
82e7bd6
Add help window
GuillaumeFavelier 76f14e0
Merge branch 'master' into time_viewer_help_window
GuillaumeFavelier 711d75c
Update window size and refactor _show_help()
GuillaumeFavelier c81964b
Use tuple instead of dict
GuillaumeFavelier b1e4db1
Refactor key bindings
GuillaumeFavelier f7339c5
Refactor keyPressEvent
GuillaumeFavelier ad1299c
Merge branch 'master' into time_viewer_help_window
GuillaumeFavelier f8e472f
Revert "Refactor keyPressEvent"
GuillaumeFavelier 440d92a
TST: try Key_questiondown
GuillaumeFavelier e7ea1b3
Refactor keyPressEvent
GuillaumeFavelier 1cbcb44
Use help menu instead of help label
GuillaumeFavelier 717ec4c
Update shortcuts
GuillaumeFavelier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather not sacrifice this much (or really any) screen real estate for this:
If it's always
?
in all of our plotters we can just document it in a tutorial and in docstrings.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... actually the intuitive way to do it without eating up screen real estate would be to add a
Help->Show MNE key bindings...
menu option at the top. If it's not too hard to do it it's a nice optionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or more completely / standardly,
Help-> Show MNE key bindings... ?
(with the?
in the right column of the menu item to indicate it's the shortcut)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion @larsoner. I'm on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to find this code snippet I did not so long ago...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found it: #7200 (comment)