-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Time viewer tool bar with SVG icons #7589
WIP: Time viewer tool bar with SVG icons #7589
Conversation
I also thought about a button like the following: that would display additionnal informations. It could be used to clarify the auto-scaling feature or time index @larsoner (relevant for #7247 (comment)) |
@GuillaumeFavelier any way we can use unicode for the icons rather than bundling new binary images? |
I don't think we'd find anything even closely as good-and-balanced-looking, tbh… also if you use a font, the icons could end up looking different on every system! -1 on unicode icons from my side for now :) |
@larsoner What could work, potentially, are FontAwesome fonts, but personally I'm in favor of bundling SVG icons |
It should be possible but it may have a totally different result on old version of PyQt5. It may require some particular processing like we did in #7257 (comment) |
@cbrnr Since you've probably been through this decision process personally with MNELAB, what's your stance on this? |
@GuillaumeFavelier Just tested on macOS and looks and works beautifully. I really like it! Also the availability of buttons now could compensate for some of the shortcomings of PyVista. For example, I don't think we'd need to hold on to the orientation slider, but we could add toolbar buttons for that instead (like in FreeView). |
Sorry, we can exclude the images and |
I'd go with SVG icons, I didn't even consider using unicode symbols. Just make sure to set |
Just to be clear, to make it work with PyQt, only the built |
Closing in favour of #7592 to move forward. At least a prototype is available here if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI goes green. Thanks for your work, @GuillaumeFavelier
Codecov Report
@@ Coverage Diff @@
## master #7589 +/- ##
==========================================
+ Coverage 90.05% 90.12% +0.07%
==========================================
Files 452 454 +2
Lines 83035 83387 +352
Branches 13127 13208 +81
==========================================
+ Hits 74780 75156 +376
+ Misses 5403 5375 -28
- Partials 2852 2856 +4 |
Works great, thanks @GuillaumeFavelier |
This PR, following a discussion with @hoechenberger and strongly inspired by cbrnr/mnelab#61, adds a tool bar with useful bindings to the features of
_TimeViewer
:It's also an item of #7162 since it adds buttons to the interface.
This is not compatible with #7592