Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG, FIX: Fix get_channel_types #7878

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Jun 8, 2020

Fixes a bug with plot_psd that was introduced by #7486. Basically the order in picks was not preserved, which was required by plot_raw_psd when there are multiple channel types.

Closes #7837

@larsoner larsoner added the backport-candidate on-merge: backport to maint/1.7 label Jun 8, 2020
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works !

@larsoner larsoner merged commit f8d2ce1 into mne-tools:master Jun 8, 2020
larsoner added a commit that referenced this pull request Jun 8, 2020
@larsoner larsoner added backported and removed backport-candidate on-merge: backport to maint/1.7 labels Jun 8, 2020
@larsoner larsoner deleted the get_channel_types branch June 8, 2020 17:26
@agramfort
Copy link
Member

agramfort commented Jun 8, 2020 via email

larsoner added a commit to larsoner/mne-python that referenced this pull request Jun 17, 2020
* upstream/master: (24 commits)
  WIP: Fix Travis (mne-tools#7906)
  WIP: Prototype of notebook viz (screencast) (mne-tools#7758)
  MRG, FIX: Speed up I/O tests, mark some slow (mne-tools#7904)
  Proper attribution for Blender tutorial (mne-tools#7900)
  MAINT: Check usage [ci skip] (mne-tools#7902)
  Allow find_bad_channels_maxwell() to return scores (mne-tools#7845)
  Warn if NIRx directory structure has been modified from original format (mne-tools#7898)
  Pin pvyista to 0.24.3 (mne-tools#7899)
  MRG: Add support for reading and writing sufaces to .obj (mne-tools#7824)
  Fix _auto_topomap_coords docstring. (mne-tools#7895)
  MRG, FIX: Ensure Info H5-writeable (mne-tools#7887)
  Website contents (mne-tools#7889)
  MRG, ENH: Add mri_resolution="sparse" (mne-tools#7888)
  MRG, ENH: Allow disabling FXAA (mne-tools#7877)
  remove "and and" [ci skip] (mne-tools#7882)
  fix evoked nave → inverse guidance (mne-tools#7881)
  ENH: Better error messages (mne-tools#7879)
  FIX : EDF+ Annotation Timestamps missing sub-second accuracy (mne-tools#7875)
  FIX: Fix get_channel_types (mne-tools#7878)
  MRG, BUG: Fix combine evokeds (mne-tools#7869)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magnetometer positions look odd in PSD plot
2 participants