Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG, BUG: Allow ref mags to have a comp grade #7965

Merged
merged 2 commits into from
Jul 6, 2020

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Jul 6, 2020

Closes #6488

@Yaocoo @Nichalas can you try it? @Nichalas at least with your test data I can now read it.

@larsoner larsoner changed the title BUG: Allow ref mags to have a comp grade MRG, BUG: Allow ref mags to have a comp grade Jul 6, 2020
@Nichalas
Copy link
Contributor

Nichalas commented Jul 6, 2020

Apparently it works.. Thanks!

@agramfort
Copy link
Member

thanks @larsoner !

@larsoner
Copy link
Member Author

larsoner commented Jul 6, 2020

Pushed a commit to make codecov happy (hopefully)

@larsoner larsoner merged commit 5ff1cb5 into mne-tools:master Jul 6, 2020
@larsoner larsoner deleted the comp branch July 6, 2020 22:16
larsoner added a commit to larsoner/mne-python that referenced this pull request Jul 8, 2020
* upstream/master: (30 commits)
  MRG: Add remove_labels to _Brain (mne-tools#7964)
  Add get_picked_points (mne-tools#7963)
  ENH: Add OpenGL info to mne sys_info (mne-tools#7976)
  [MRG] Fix reject_tmin and reject_tmax for reject_by_annotation in mne.Epochs (mne-tools#7967)
  mrg: Add scalar mult and div operators for AverageTFR (mne-tools#7957)
  MRG, MAINT: Cleaner workaround for Sphinx linking issue (mne-tools#7970)
  MRG, ENH: Speed up epochs.copy (mne-tools#7968)
  MRG, BUG: Allow ref mags to have a comp grade (mne-tools#7965)
  do not forget to pass adjacency (mne-tools#7961)
  [MRG] fix Issue with stc.project after restricting to a label (mne-tools#7950)
  Only process nirx event file if present (mne-tools#7951)
  MRG+1: BUG: info['bads'] order shouldn't matter in write_evokeds() (mne-tools#7954)
  Fix some small glitches introduced via mne-tools#7845 (mne-tools#7952)
  Add time player (mne-tools#7940)
  MAINT: Clean up VTK9 offset array [circle front] (mne-tools#7953)
  MAINT: Skip a few more on macOS (mne-tools#7948)
  fix links [skip travis] (mne-tools#7949)
  MRG, MAINT: Tweak CIs (mne-tools#7943)
  MRG, BUG: Fix vector scaling (mne-tools#7934)
  MRG, VIZ, BUG: handle CSD channel type when topo plotting (mne-tools#7935)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTF data loading with non-zero compensation grade error
3 participants