MRG, ENH: Add flatmap #8082
MRG, ENH: Add flatmap #8082
Conversation
|
cc @johnsam7 this should help prepare us to visualize cortex + cerebellum flatmaps |
|
we should document or point to external doc on how to compute the flatmaps. Last time I tried It required manual work. |
|
I have no idea how actually. I just know fsaverage has them. For now maybe it's enough just to tell people to morph? |
|
anyone has experience with this here?
|
|
There are tutorials here:
I'll add a note that it's available for fsaverage and otherwise you need to do something like the above while adding tests soon |
|
ok
… |
|
Ready for review/merge from my end |
|
@GuillaumeFavelier do you want to take a look? |
|
CircleCI failure is just the one fixed by #8109 |
| @@ -409,6 +418,9 @@ def add_data(self, array, fmin=None, fmid=None, fmax=None, | |||
| clim : dict | |||
| Original clim arguments. | |||
| %(src_volume_options_layout)s | |||
| colorbar_kwargs : dict | None | |||
There was a problem hiding this comment.
Do we have a plan with colorbar_kwargs? I don't see it used in this PR.
There was a problem hiding this comment.
Indeed I don't use it in this example, locally I use it to set the tick and title sizes. Do you think I should update an example?
There was a problem hiding this comment.
Yes, it would be great to have it used once at least.
There was a problem hiding this comment.
|
what is weird is that you can still rotate flat maps. Once you have
started rotating it's not clear how to reset the view.
is there a possible easy fix?
|
|
It would require writing a new VTK interactor, so no not really. We should probably add a keyboard command to _Brain that resets to the original views |
|
We should probably add a keyboard command to _Brain that resets to the
original views
+1. 'r' key?
|
|
Sure, I would say it should reset the time index and views -- basically get everything back to how it was when the viz was opened |
|
+1
|
|
Added it as an item in #7162 |
* Add screenshot button * Ensure valid filename * Make the name shorter * Use Brain screenshot * Click on all buttons * Count the buttons too * Add a tool bar to the standard _Renderer * Improve testing of standard _Renderer * DRY a little bit * Use concatenate_images * Make it shorter and more complicated * Fix style * Add centered parameter * Comment slicing * make it work on mac * Remove cruft * Update comments * Remove more comments * Generate screenshot filename * Start over and test * Test both qt and notebook * The pragmatic approach * Improve testing * Fix test * ENH: Faster test * BUG: More explicit height * Fix dangling objects issue * Change order * Try #8082 * FIX: Fix sizing * FIX: Use concatenate_images * FIX: dtype * MAINT: Notebook test * FIX: Flake * Speed up test.ipynb * FIX: Bad Qt/VTK combo Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
plot_visualize_stc.pyon my system with this:brainCloses #8081