Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: Link colorbar controls in _LinkViewer #8126

Merged
merged 2 commits into from
Aug 18, 2020
Merged

MRG: Link colorbar controls in _LinkViewer #8126

merged 2 commits into from
Aug 18, 2020

Conversation

GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Aug 17, 2020 •
edited
Loading

This PR links the colorbar controls in _LinkViewer and adds a colorbar parameter to link_brains().

  • Document the colorbar parameter

It's an item of #7162

@GuillaumeFavelier GuillaumeFavelier self-assigned this Aug 17, 2020
@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Aug 18, 2020
Closed
86 tasks
@GuillaumeFavelier GuillaumeFavelier changed the title WIP: Link colorbar controls in _LinkViewer MRG: Link colorbar controls in _LinkViewer Aug 18, 2020
agramfort
agramfort approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsoner merge if happy

@larsoner larsoner merged commit c3283d3 into mne-tools:master Aug 18, 2020
@larsoner
Copy link
Member

Thanks @GuillaumeFavelier

@GuillaumeFavelier GuillaumeFavelier deleted the timeviewer_link_colorbar branch August 18, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels
VIZ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeFavelier @larsoner @agramfort