-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG, MAINT: add codemeta #8669
MRG, MAINT: add codemeta #8669
Conversation
The authors look like something that could be easily scripted except for the ORCID ID. |
CIs all green, ready for review/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some ideas for making things more DRY/reduce number of steps this adds to our processes.
Also can you write a corresponding line in the wiki for making a release for example:
4. PENDING PR 8669: Check `tools/generate_codemeta.py` against new names in `doc/changes/latest.inc` for compound surnames, then run `tools/generate_codemeta.py` to update `codemeta.json`
Choosing the number/location based on probably needing to come after changing the version, but before pushing a commit, and before making the GitHub release? I think this plus my inline suggestions would reduce the "added effort" to support this to be ~1 minute during the "making a release" stage, which would be great!
CIs all green again, ready for second review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the only thing we have to do from now on (other than make sure this code still works) is, during release:
- Edit tools/generate_codemeta.py to update the compound_surnames variable (if needed, based on new contributors from the changelog). Then from the tools folder run python generate_codemeta.py to update the codemeta metadata for this release.
Sounds easy enough to me, +1 for merge
This comment has been minimized.
This comment has been minimized.
OK, local testing in an env using mne-stable seems to work correctly now. after running it I manually back-dated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @drammock ! merge if good to go from your end
* add codemeta.json (metadata) * update mailmap * add generator script * regen JSON * remove leading newline * cleaner; better comments * exclude codemeta from manifest * safer check * better comments, automate downloadUrl * clearer variable names * regen JSON * DRY dependency versions; changes from Eric's review * fix path * regen metadata
Boilerplate was generated using https://codemeta.github.io/codemeta-generator/ and the things that might change (release date, release version, dependencies, and authors) are update by the new script
tools/generate_codemeta.py
which can be run at release time.