-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Actually use all caches #8702
Conversation
... also the |
I noticed that the restoring step only really restored two of our 8 keys, I think this is because the other ones likely exceeded some implicit allowed cache size -- I don't see a limit documented anywhere but I suspect this is what's happening. In any case it shouldn't hurt to split them, and I've documented their decompressed size on disk. I'll go ahead and merge this once CircleCI is happy, we're going to need to have it build on |
df38cce
to
11f5651
Compare
2bb30a6
to
b402bf0
Compare
* upstream/master: MAINT: Actually use all caches (mne-tools#8702) MRG: Prototype of notebook viz (ipyvtk) (mne-tools#8503) MRG: Use caching in Github Actions and Azure Pipelines (mne-tools#8695)
According to the CircleCI docs it looks like the cache restore uses whichever key it finds first, treating all subsequent ones as fallbacks. So really we should restore each individually. In theory this should make our CircleCI full build faster and more reliable as it can just use the cached version rather than redownloading every time.