Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Brain locale #9179

Merged
merged 1 commit into from
Mar 22, 2021
Merged

FIX: Brain locale #9179

merged 1 commit into from
Mar 22, 2021

Conversation

GuillaumeFavelier
Copy link
Contributor

This small PR fixes the issue with Brain locale.

master PR
image image

It's an item of #7162

@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 22, 2021
@GuillaumeFavelier
Copy link
Contributor Author

Feel free to try it @hoechenberger, @agramfort 👍

@hoechenberger
Copy link
Member

Perfect, thanks!

@GuillaumeFavelier GuillaumeFavelier merged commit 75a408e into mne-tools:main Mar 22, 2021
@GuillaumeFavelier GuillaumeFavelier deleted the fix/brain_locale branch March 22, 2021 11:18
@larsoner
Copy link
Member

Am I remembering correctly that the colorbar has the same problem on your system? Did this fix that as well, or do we need a fix on the VTK end for that?

@GuillaumeFavelier
Copy link
Contributor Author

the colorbar has the same problem on your system?

Yes I just noticed. I don't know a fix for that except playing with my env variables.

@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Mar 22, 2021
Closed
86 tasks
@larsoner
Copy link
Member

larsoner commented Mar 22, 2021 •
edited
Loading

Can you try doing QLocale.setDefault(QLocale.c()) at the first import of Qt (before any other VTK windows / applications are created)? It's not the right solution to change the global state like this (at least not without setting it back), but it would at least tell us if it's perhaps the Qt global state change breaking things in VTK:

https://gitlab.kitware.com/vtk/vtk/-/issues/17660

Also can you see if you have this problem in a VTK / PyVista scalarbar example that does not use Qt? It would help us isolate the problem to VTK+Qt instead of VTK alone as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoechenberger hoechenberger hoechenberger approved these changes

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeFavelier @hoechenberger @larsoner