-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG, ENH: Add NIRSport support #9348
Merged
+266
−33
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
e7b7c37
[fNIRS]feat: add nosatflags_wlX files support
06f46c0
[fNIRS]feat: add nosatflags tests for NIRSport1
8e73ca4
[fNIRS]feat: add 'NaN' annotations
184c91e
[fNIRS]feat: add a test for data with annotated_nan
aa773c2
[fNIRS] update release number and hash following the addition of NIRS…
rderollepot 0f62cc3
Merge remote-tracking branch 'upstream/main' into addNIRSport
rob-luke 189cf51
Add to docs
rob-luke 258a9ec
Improve wording and errors
rob-luke e285310
Use real data for tests
rob-luke 51154aa
Test that nans are returned. FAILING
rob-luke 911e6f4
More tests. Still strange behaviour
rob-luke 2a78edf
Found cause of strange behaviour
rob-luke a66df0c
Flake
rob-luke 5b23b87
Add annotation description to docs
rob-luke 097df94
Apply suggestions from code review
rob-luke 75ea78d
Spelling
rob-luke e45afaf
Merge branch 'addNIRSport' of github.com:rob-luke/mne-python into add…
rob-luke 278c04b
Fix verbose
rob-luke 8c6a8e1
Further suggestions from review
rob-luke db59e1a
Use new test file
rob-luke 79e3b37
Flake
rob-luke ad8e112
Fix bug in logic
rob-luke b7544ff
Flake
rob-luke 2f70d8a
Doc
rob-luke 7fe2fd0
doc
rob-luke fbb4743
Update utils.py
rob-luke 9643d43
Merge branch 'main' into addNIRSport
rob-luke 5f76cdf
FIX: Two-pass approach if needed
larsoner 9507790
FIX: Missed some
larsoner 715042c
ENH: Channel-specific
larsoner 01418c1
FIX: Paired
larsoner 94102c4
FIX: No need to ignore
larsoner ac730cc
DOC: latest
larsoner 3fc6621
Merge remote-tracking branch 'upstream/main' into addNIRSport
larsoner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swy7ch @rderollepot let me know if you want different URLs here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is great for me, thanks 👍
I also want to take this opportunity to say that I am really grateful for your help @larsoner and @rob-luke in seing that the great contribution @swy7ch started almost a year ago can come to an end, improving it with new features along the way. We are still very new to MNE in the lab (it started with David's internship), and I am not sure I would have been able to finish it myself (or it would have take me ages 😅).