-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: Add support for NIRSport2 devices #9401
Conversation
Tests pass locally. I will need to poke CIs again when testing data is merged. |
Thanks |
@larsoner could you please review this PR. I think the failing tests are due to https://github.com/mne-tools/mne-testing-data/releases/tag/0.120 not anything ive done. |
Yes for now just delete the line
and it'll be fixed properly in #9406 I also pushed a fix that was causing failures in two of the CIs |
@larsoner and @agramfort could you please review (thanks larsoner for the first pass getting things green). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nitpick
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
@larsoner I think I hit all your suggestions. Please review and merge if happy. |
I think the last thing is |
Reference issue
Closes #9371
Related to mne-tools/mne-testing-data#86
What does this implement/fix?
Additional information
This device can export simultaneously as SNIRF and vendor format. So I made a simultaneous recording and then ensure that data from the two files match if read with MNE.
The data is identical (as demonstrated in tests). However, the metadata is different across files (e.g. subject ID). I am in contact with the vendor to discuss this. So I don't think it's a reader bug.