Coreg fixes #9928
Merged
Coreg fixes #9928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloyl
commented
Oct 30, 2021
larsoner
reviewed
Nov 1, 2021
| @@ -215,10 +220,23 @@ def _set_current_fiducial(self, fid): | |||
| def _set_info_file(self, fname): | |||
| if fname is None: | |||
| return | |||
| if not self._check_fif('info', fname): | |||
|
|
|||
| # info file can be anything supported by read_raw | |||
There was a problem hiding this comment.
On main it can actually be more than this -- it could be an evoked or epochs etc. -- really anything that stored an info in a .fif. This change makes it so that, for FIF, only the raw variants are supported. I'll push a change to fix this just based on a splitext check
There was a problem hiding this comment.
Oh never mind, I misunderstood this code -- looks like you do handle fif using a read-info-like operation below!
larsoner
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle two issues I raised in #8833,
info['dig']missing some types of dig pointsdigobjects.still needshasn't been released so no need.latest.inc