Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3-D screenshot functionality #1191

Open
tischi opened this issue Nov 25, 2024 · 11 comments
Open

Add 3-D screenshot functionality #1191

tischi opened this issue Nov 25, 2024 · 11 comments
Assignees

Comments

@tischi
Copy link
Contributor

tischi commented Nov 25, 2024

Would there be a way to export a stack of images around a saved View in Mobie? e.g. same as the Screenshot function but 50 slices above and below.

https://forum.image.sc/t/export-stack-of-images-around-a-saved-view-in-mobie/105454

@tischi
Copy link
Contributor Author

tischi commented Nov 26, 2024

@tischi tischi self-assigned this Nov 26, 2024
@mcdomart
Copy link

mcdomart commented Nov 26, 2024

Hi @tischi ,
Thanks for the speedy reply!
Happy to chat here if you need anything!
Thanks!
MC

@tischi
Copy link
Contributor Author

tischi commented Nov 26, 2024

Hi @mcdomart,

I already started implementing this :-)

My question is about the z-spacing. I would add another UI element that allows the user to enter the z-spacing in the same manner as the "Sampling" which is the x/y spacing.

OK?

@mcdomart
Copy link

Awesome and yes z-spacing choice in UI sounds great. Having an idea or option of best resolution possible would be ideal though

@tischi
Copy link
Contributor Author

tischi commented Nov 26, 2024

Interesting idea.

Currently there is also no indication given for the highest possible x/y resolution. Maybe this could be added, but in general this is not trivial, because

  1. There can be several images in the current field of view with different underlying resolutions
  2. The current viewer plane does not have to be parallel to any of the image axes

@tischi
Copy link
Contributor Author

tischi commented Nov 26, 2024

@mcdomart please update Fiji and test the new Take ScreenShot Stack functionality!

@mcdomart
Copy link

Oh wow that was super fast thank you! I'll test it now!

tischi added a commit that referenced this issue Nov 26, 2024
@mcdomart
Copy link

mcdomart commented Nov 26, 2024

It works great, thanks! One question though. Would it be possible to change the number of zeros after the comma to 3 in the sampling value displayed in the UI? There are currently only two, which results in rounding up in the display. For example, when I input 0.007, 0.01 is displayed. When I type 0.001, the display shows 0.00. The export does appear to be at the correct resolution though.

@tischi
Copy link
Contributor Author

tischi commented Nov 26, 2024

OK, done:

image

I also changed to code to initialise the z-spacing to the same value as the x/y spacing such that one would get an isotropically sampled volume. This maybe be oversampling in many case, but this would also depend on the current orientation of the viewer plane, so I feel this is a reasonable default.

I did not push the changes yet...anything else you'd like to see improved?

@mcdomart
Copy link

It looks great, thanks! Agree re' isotropic default. I can't think of anything else right now, other than the non trivial issue of getting the right sampling for a given view.
Actually, minor comment is on the export format. I get an RBG export that I don't need, and a composite 32 bit tif. I only have one 8 bit EM dataset in my Mobie project and only export a small region, but I could imagine size issues with 32 bits export. Would it be possible to have the option to choose to export as 8 bits instead of 32 bits?

@tischi
Copy link
Contributor Author

tischi commented Nov 26, 2024

I only have one 8 bit EM dataset in my Mobie project and only export a small region, but I could imagine size issues with 32 bits export. Would it be possible to have the option to choose to export as 8 bits instead of 32 bits?

Very good point. My issue was that there can be images of different datatypes visible at the same time in BDV and thus I needed a "container" datatype that could represent all of them. However if there are only 8 bit images that does not make sense. I will look into restricting the output to 8 bit if there are only 8 bit images visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants