Fix FileNotFoundException: ~.maestro/sessions
#1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,10 @@ import kotlin.concurrent.write | |||
| class KeyValueStore(private val dbFile: File) { | |||
| private val lock = ReentrantReadWriteLock() | |||
There was a problem hiding this comment.
Can this class be called by multiple threads? Would that be a problem for creating new file.
There was a problem hiding this comment.
In theory, yes and then that could be a problem, I think.
But in practice, right now, a KeyValueStore is effectively a singleton. It's only created here:
and SessionStore is a singleton
lucaswiechmann
approved these changes
Jul 29, 2024
|
Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1842