Fix Android Parallel/Shards Race Condition #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rasyid7, thanks a lot for this PR. I tested it and it does fix the issue. That said I don't want to merge this as is, because the code is already complex. I'd prefer we find a root cause and fix that instead. Would you be up to do that? |
|
hi @bartekpacia , surely this is just hotfix. but if there's someone able to find the root cause, feel free to create a PR. |
|
I see. To unblock users, I'm going to merge it as it, because it does fix the issue. That said, I will try to get back as soon as I have some free cycles, and get it fixed properly. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I think this is because of the shards race condition
So by adding a delay will fix the race condition
Testing
Issues fixed
#1853 Unable to run parallel/sharded tests on Android