Js log dollar sign

[tokou]

Proposed changes

• I updated the regexes in fun String.evaluateScripts(jsEngine: JsEngine) to not prevent the script to have any dollar sign
• I'm confident this fixes the linked issue
• I'm not confident enough this does not brake on a weird edge case
• I tried thinking of some JS content that contains a dollar sign and that would brake due to this change but I don't have any idea. Maybe you'll find one
• I added forwarding of the js console to maestro log file
• I added a MAESTRO_CLI_LOG_LEVEL env var to limit log output level if needed

Testing

• Added unit test
• Tested with following e2e file

appId: com.example.example
---
- launchApp
- evalScript: ${console.log('Hello!')}
- evalScript: ${console.log('Hello money! $')}
- evalScript: ${console.log('Hello money! \$')}
- evalScript: ${console.log('$')}
- evalScript: ${console.log('\$')}

 ║
 ║  > Flow: dollar
 ║
 ║    ✅   Launch app "com.example.example"
 ║    ✅   Run ${console.log('Hello!')}
 ║         Log messages:
 ║           Hello!
 ║    ✅   Run ${console.log('Hello money! $')}
 ║         Log messages:
 ║           Hello money! $
 ║    ✅   Run ${console.log('Hello money! \$')}
 ║         Log messages:
 ║           Hello money! $
 ║    ✅   Run ${console.log('$')}
 ║         Log messages:
 ║           $
 ║    ✅   Run ${console.log('\$')}
 ║         Log messages:
 ║           $
 ║

Issues fixed

Fixes #1760

Fixes #1744

[Fishbowler]

I wonder what the original author intended with the original regex here?

[tokou]

Yes, I believe it was to detect anything that's encosed in ${} and that does not contain $ inside

[Fishbowler]

But why would they have done specific work to exclude the dollar, if it were as simple as just .*? ?
Is there an additional risk we've not considered?