Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one when specifying count with inputText #2123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix off-by-one when specifying count with inputText #2123

wants to merge 2 commits into from

Conversation

Fishbowler
Copy link
Contributor

@Fishbowler Fishbowler commented Nov 3, 2024 •
edited
Loading

Proposed changes

Self-evident 1 character change to fix a problem where we're always deleting 1 character extra. Background in the linked issue.

Testing

- inputText: 'testing'
- assertVisible: 'testing'
- eraseText: '3'
- assertNotVisible: 'testing'
- assertVisible: 'test'

Issues fixed

#2122

@Fishbowler
Fix off-by-one when specifying count with inputText (fixes mobile-dev…
df9fc2f 
…-inc#2122)
@Fishbowler
Add a short delay between backspace taps to ensure the correct number…
47c1305 
… of taps occur

Repeated tests show that the emulator can be slightly inconsistent and occasionally add an extra tap
@Fishbowler Fishbowler mentioned this pull request Nov 3, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Fishbowler