Auto-restart xctest runner and idb_companion on connection error #882
Conversation
berikv
force-pushed
the
xctestrunner_restart_onerror
branch
from
9fba62c
to
9c42868
Compare
berikv
changed the title
berikv
force-pushed
the
xctestrunner_restart_onerror
branch
from
48b8f0d
to
e879513
Compare
…own maestro studio
maestro-xcuitest-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt
Outdated
Show resolved
Hide resolved
Devices are not rebooted, only idb is restarted |
seems that applesimutils causes some kinda device reboot, but I don't see an easy workaround there https://mobile-dev-inc.slack.com/archives/C041FU72T54/p1678455454132919?thread_ts=1678452522.490319&cid=C041FU72T54 |
It looks more like a UI refresh, applesimutils probably kills some simulator os-level gui process to make its changes persistent. Do we really want to warn the user about that though? And through which channel? We currently don't have a very simple way to reliable warn the user about something. Maestro's ansi UI overwrites any println() that we do. I could trigger a system alert, but I don't think we'd make friends that way.. |
berikv
force-pushed
the
xctestrunner_restart_onerror
branch
from
dd72b2d
to
6e97409
Compare
| object IdbCompanion { | ||
| private val logger = DebugLogStore.loggerFor(IdbCompanion::class.java) | ||
|
|
||
| // TODO: Understand why this is a separate method from strartIdbCompanion |
There was a problem hiding this comment.
@amanjeetsingh150 Do you know the details on why this was implemented differently than startIdbCompanion?
Proposed Changes
When a connection error occurs on either xctest runner or on idb_companion, restart that specific service.
Testing
Early testing looks promising, more testing is needed.
Tested by:
./maestro studioin one terminal./maestro test samples/ios-flow.yamlseveral times in another terminalIssues Fixed
launchApp would cause idb_companion to shut down due to its internal setPermissions call. idb_companion is needed as a fallback for getViewHierarchy for ReactNative (and other apps with big view hierarchies).