Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTE bandwidth predictor fix #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Codeman-from-unknown-city

This fix make LTE bandwidth predictor works.

What changed:

  • LteBandwidthPredictor waits for event from TrackCellInfoAnalyzer, but the event is dropped by Analyzer base class because it contains None in data field:

TrackCellInfoAnalyzer notifier method:

    def __callback_mib_cell(self, msg):
        self.__mib_antenna = msg.data['Number of Antenna']
        self.__mib_dl_bandwidth = msg.data['DL BW']
        self.__mib_cell_id = msg.data['Physical Cell ID']
        self.__mib_freq = msg.data['Freq']
        event = Event(None, 'MIB_CELL', None)   # sends event with
        self.send(event)                        # 'None' in data field

Event is filtered in Analyzer base method:

    def recv(self, module, event):
        ...
        if not event.data:  # the event is dropped here
            return
        ...

In result the LteBandwidthPredictor never starts.

  • Fixed arrays indices calculations in LteBandwidthPredictor itself. The previous version may create float indices what leads to crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant