-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generating coverage reports #1173
Conversation
1621ce8
to
82d80e8
Compare
There's lots of autoconf magic here, which is a bit inscrutable to me, as a non-autoconf-wizard. Can you provide a few instructions about how to use this (how to have coverage data be collected, and how to generate an html report)? |
Sure! As a pre-req, make sure you have
This will run the tests and process the gcov output with lcov, and produce an html report in a subdirectory matching the pattern I can also add these instructions to the README in an additional commit to this PR if you'd like. |
03123f0
to
da2e6b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add $(CODE_COVERAGE_CFLAGS)
and $(CODE_COVERAGE_LIBS)
to src/examples/Makefile.am as well?
This change adds autoconf/automake support for building all of mosh with gcov, and generates an lcov html report. This allows seeing which parts ofthe source tree have good test coverage, and which can be shored up. Eventually, it would be good to hook this up to Github Actions to be generated automatically.
This change adds autoconf/automake support for building all of mosh
with gcov, and generates an lcov html report. This allows seeing which
parts ofthe source tree have good test coverage, and which can be
shored up. Eventually, it would be good to hook this up to Github
Actions to be generated automatically.