Reduce code owners to CODEOWNERS and settings.yml
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `CODEOWNERS` file was used to mark most code directories with code owners. Require code owners reviews is on for settings.yml security and at least 3 code owners need to be listed so a code owner can make a change, get a review from another code owner and have one code owner OOO. These settings and requirements resulted in the inability to leverage team auto-assignment, <https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team#about-auto-assignment>. Now code owners have been limited to only the `CODEOWNERS` and `settings.yml` files so that team auto assignment works.
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
jcape
approved these changes
May 5, 2023
❌ Unreviewed dependencies found
|
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage ? 67.48%
=======================================
Files ? 4
Lines ? 1058
Branches ? 0
=======================================
Hits ? 714
Misses ? 344
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
varsha888
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
CODEOWNERSfile was used to mark most code directorieswith code owners. Require code owners reviews is on for settings.yml
security and at least 3 code owners need to be listed so a code owner
can make a change, get a review from another code owner and
have one code owner OOO. These settings and requirements resulted in the
inability to leverage team auto-assignment,
https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team#about-auto-assignment.
Now code owners have been limited to only the
CODEOWNERSandsettings.ymlfiles so that team auto assignment works.Motivation