Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rust version #16

Merged
merged 9 commits into from
Mar 11, 2022
Merged

Upgrade rust version #16

merged 9 commits into from
Mar 11, 2022

Conversation

remoun
Copy link
Contributor

@remoun remoun commented Mar 3, 2022

This entails switching from llvm_asm! to the newly stabilized asm!.

Supports mobilecoinfoundation/mobilecoin#1408

@remoun remoun requested review from jcape, eranrund and cbeck88 March 3, 2022 00:29
@remoun remoun self-assigned this Mar 3, 2022
@remoun remoun mentioned this pull request Mar 3, 2022
Merged
@remoun remoun requested a review from cbeck88 March 3, 2022 02:18
@remoun
Copy link
Contributor Author

remoun commented Mar 4, 2022 •
edited
Loading

Benchmarks are looking roughly equivalent. The new impl seems to be slightly faster for the cmov_a64 benches, and slightly slower for cmov_a8.

cbeck88
cbeck88 approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@cbeck88 cbeck88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you for your work on this

I spent a while looking at codegen, and it looks basically the same to me in all cases I looked at. Thanks for running the benchmarks, those also look good to me

@jcape jcape requested a review from wjuan-mob March 11, 2022 21:10
@remoun remoun merged commit 7d59741 into master Mar 11, 2022
@remoun remoun deleted the upgrade-rust-version branch March 11, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeck88 cbeck88 cbeck88 approved these changes

@jcape jcape Awaiting requested review from jcape

@eranrund eranrund Awaiting requested review from eranrund

@wjuan-mob wjuan-mob Awaiting requested review from wjuan-mob

Assignees

@remoun remoun

Labels
None yet
Projects
Blockchain Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remoun @cbeck88