Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on Enclave Fatal Error #3558

Merged
merged 7 commits into from
Sep 13, 2023
Merged

Conversation

dolanbernard
Copy link
Contributor

  • Removed ledger enclave check
  • Added check for result of enclave calls to panic on all fatal errors

Motivation

Any time an enclave encounters a non-recoverable error, panic the untrusted code to force a restart.

Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM some suggestions that may be nice to get in, but not blockers

enclave-boundary/src/untrusted.rs Outdated Show resolved Hide resolved
enclave-boundary/src/untrusted.rs Outdated Show resolved Hide resolved
enclave-boundary/src/untrusted.rs Outdated Show resolved Hide resolved
enclave-boundary/src/untrusted.rs Outdated Show resolved Hide resolved
dolanbernard and others added 2 commits September 13, 2023 13:36
Co-authored-by: Eran Rundstein <eran@rundste.in>
Co-authored-by: Eran Rundstein <eran@rundste.in>
enclave-boundary/src/untrusted.rs Outdated Show resolved Hide resolved
enclave-boundary/src/untrusted.rs Outdated Show resolved Hide resolved
dolanbernard and others added 2 commits September 13, 2023 14:14
Co-authored-by: Nick Santana <nick@mobilecoin.com>
@dolanbernard dolanbernard merged commit c524363 into release/v5.0 Sep 13, 2023
81 checks passed
@dolanbernard dolanbernard deleted the enclave-fatal-error-panic branch September 13, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants