Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fog-ingest to support getting ledger data from a remote mobilecoind #3748

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

eranrund
Copy link
Contributor

Motivation

This PR is a followup to #3701. It changes fog-ingest-server to use the BlockProvider trait and support either getting block data from local lmdb files, or from a remote mobilecoind instance. Doing this will allow us to slightly reduce our Azure storage cost.

To verify the performance of this I deployed this branch twice, once without the helm changes and once with it and ran the fog-test-client. I observed the prometheus metrics, and here's what I saw.

Local ledger:

fog_test_client_tx_received_time_bucket{le="1"} 0
fog_test_client_tx_received_time_bucket{le="2"} 0
fog_test_client_tx_received_time_bucket{le="2.5"} 26
fog_test_client_tx_received_time_bucket{le="3"} 27
fog_test_client_tx_received_time_bucket{le="3.5"} 34
fog_test_client_tx_received_time_bucket{le="4"} 46
fog_test_client_tx_received_time_bucket{le="4.5"} 49
fog_test_client_tx_received_time_bucket{le="5"} 49
fog_test_client_tx_received_time_bucket{le="5.5"} 49
fog_test_client_tx_received_time_bucket{le="6"} 49
fog_test_client_tx_received_time_bucket{le="6.5"} 49
fog_test_client_tx_received_time_bucket{le="7"} 49
fog_test_client_tx_received_time_bucket{le="7.5"} 49
fog_test_client_tx_received_time_bucket{le="8"} 49
fog_test_client_tx_received_time_bucket{le="9"} 49
fog_test_client_tx_received_time_bucket{le="10"} 49
fog_test_client_tx_received_time_bucket{le="12"} 49
fog_test_client_tx_received_time_bucket{le="14"} 50
fog_test_client_tx_received_time_bucket{le="16"} 50
fog_test_client_tx_received_time_bucket{le="18"} 50
fog_test_client_tx_received_time_bucket{le="20"} 50
fog_test_client_tx_received_time_bucket{le="+Inf"} 50

Remote ledger:

fog_test_client_tx_received_time_bucket{le="1"} 0
fog_test_client_tx_received_time_bucket{le="2"} 0
fog_test_client_tx_received_time_bucket{le="2.5"} 23
fog_test_client_tx_received_time_bucket{le="3"} 23
fog_test_client_tx_received_time_bucket{le="3.5"} 31
fog_test_client_tx_received_time_bucket{le="4"} 49
fog_test_client_tx_received_time_bucket{le="4.5"} 49
fog_test_client_tx_received_time_bucket{le="5"} 49
fog_test_client_tx_received_time_bucket{le="5.5"} 49
fog_test_client_tx_received_time_bucket{le="6"} 49
fog_test_client_tx_received_time_bucket{le="6.5"} 49
fog_test_client_tx_received_time_bucket{le="7"} 49
fog_test_client_tx_received_time_bucket{le="7.5"} 49
fog_test_client_tx_received_time_bucket{le="8"} 49
fog_test_client_tx_received_time_bucket{le="9"} 49
fog_test_client_tx_received_time_bucket{le="10"} 49
fog_test_client_tx_received_time_bucket{le="12"} 49
fog_test_client_tx_received_time_bucket{le="14"} 49
fog_test_client_tx_received_time_bucket{le="16"} 49
fog_test_client_tx_received_time_bucket{le="18"} 49
fog_test_client_tx_received_time_bucket{le="20"} 49
fog_test_client_tx_received_time_bucket{le="+inf"} 49

The numbers appear very similar, so I think it is okay to move forward with this.

@eranrund eranrund merged commit 1c2180b into release/v5.2 Nov 29, 2023
155 checks passed
@eranrund eranrund deleted the feature/fog-ingest-mobilecoind branch November 29, 2023 00:19
@nick-mobilecoin nick-mobilecoin mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants