Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slam tool to consensus server repo #733

Merged
merged 5 commits into from
Mar 9, 2021

Conversation

cbeck88
Copy link
Contributor

@cbeck88 cbeck88 commented Feb 23, 2021

The slam tool is a load testing tool for the consensus servers.
Generally, test code should be versioned with the code under test.

This moves the slam tool to the same repo as the consensus servers,
and will make it easier to run this test in CD and more easily use
it to validate changes to the consensus servers.

The slam tool is a load testing tool for the consensus servers.
Generally, test code should be versioned with the code under test.

This moves the slam tool to the same repo as the consensus servers,
and will make it easier to run this test in CD and more easily use
it to validate changes to the consensus servers.
@cbeck88 cbeck88 requested review from jcape, joekottke, mfaulk, eranrund, sugargoat and a team February 23, 2021 22:01
Copy link
Contributor

@eranrund eranrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some documentation things need to be improved but we know the code is doing its job :)

slam/Cargo.toml Outdated Show resolved Hide resolved
slam/README.md Outdated Show resolved Hide resolved
slam/src/config.rs Show resolved Hide resolved
@cbeck88
Copy link
Contributor Author

cbeck88 commented Feb 23, 2021

@jcape lmk if the updates for HardcodedCredentialsProvider looks right, i mostly copied from mobilecoind

Do you guys think the crate should be mc-slam now?

@cbeck88 cbeck88 requested a review from eranrund February 23, 2021 23:46
@jcape
Copy link
Contributor

jcape commented Feb 23, 2021

Do you guys think the crate should be mc-slam now?

Yep (will review inline for the HCP stuff)

Copy link
Contributor

@jcape jcape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming it runs properly against deployed networks. I'd remove some of the weird stuff from README.md, though, like references to specific networks or repositories that people may not have access to...

@cbeck88
Copy link
Contributor Author

cbeck88 commented Feb 24, 2021

TODO:

  • deploy and run slam as in instructions

@cbeck88 cbeck88 dismissed eranrund’s stale review March 9, 2021 04:59

in discussion with Sara, we will improve the README at a later date. if we do this we have one less thing to worry about when open sourcing fog repo

@cbeck88 cbeck88 merged commit 264b366 into mobilecoinfoundation:master Mar 9, 2021
@cbeck88 cbeck88 deleted the add_slam branch March 9, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants