-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slam tool to consensus server repo #733
Conversation
The slam tool is a load testing tool for the consensus servers. Generally, test code should be versioned with the code under test. This moves the slam tool to the same repo as the consensus servers, and will make it easier to run this test in CD and more easily use it to validate changes to the consensus servers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some documentation things need to be improved but we know the code is doing its job :)
@jcape lmk if the updates for Do you guys think the crate should be |
Yep (will review inline for the HCP stuff) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming it runs properly against deployed networks. I'd remove some of the weird stuff from README.md
, though, like references to specific networks or repositories that people may not have access to...
TODO:
|
in discussion with Sara, we will improve the README at a later date. if we do this we have one less thing to worry about when open sourcing fog repo
The slam tool is a load testing tool for the consensus servers.
Generally, test code should be versioned with the code under test.
This moves the slam tool to the same repo as the consensus servers,
and will make it easier to run this test in CD and more easily use
it to validate changes to the consensus servers.