Skip to content

Commit

Permalink
Allow merge commits
Browse files Browse the repository at this point in the history
Previously merge commits were disallowed. When using stacked PRs, if the
initial PR uses a squash merge, git and github loose the information to
associate the initial commits in subsequent PRs as belonging to the
initial PR. This results in github saying there are merge conflicts.
Using merge commits allows github to better keep track of which commits
are unique to each PR.
  • Loading branch information
nick-mobilecoin committed May 5, 2023
1 parent 871334e commit f67c064
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ repository:
has_downloads: false
default_branch: main
allow_squash_merge: true
allow_merge_commit: false
allow_merge_commit: true
allow_rebase_merge: false
allow_auto_merge: true
delete_branch_on_merge: true
Expand Down Expand Up @@ -82,7 +82,8 @@ branches:
protection:
required_pull_request_reviews:
require_code_owner_reviews: true
required_approving_review_count: 1
required_approving_review_count: 2
dismissal_restrictions: null
required_conversation_resolution: true
required_status_checks:
strict: false
Expand Down Expand Up @@ -113,5 +114,4 @@ branches:
- "test (stable)"
- coverage
enforce_admins: true
required_linear_history: true
restrictions: null

0 comments on commit f67c064

Please sign in to comment.